Add restart language server command#12952
Merged
Merged
Conversation
Member
|
command name LGTM |
|
@jakebailey Oh I just noticed you're on the language server team, never mind me then. You got this :) |
6 tasks
jakebailey
force-pushed
the
restart-ls-command
branch
from
August 3, 2020 21:53
8cb4d2a to
8b28240
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #12952 +/- ##
==========================================
- Coverage 59.81% 59.78% -0.04%
==========================================
Files 670 670
Lines 37163 37183 +20
Branches 5264 5265 +1
==========================================
- Hits 22230 22228 -2
- Misses 13805 13824 +19
- Partials 1128 1131 +3
Continue to review full report at Codecov.
|
karrtikr
self-requested a review
August 4, 2020 21:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #3073
Uses the existing language server restarting mechanism, which is already used for things like interpreter changes and such.
Has sufficient logging.Has telemetry for enhancements.Test plan is updated as appropriate.package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).The wiki is updated with any design decisions/details.